Remove compliant ignored ruff rules #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5649 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
tkknight
approved these changes
Dec 18, 2023
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 18, 2023
* upstream/main: ruff NPY rule compliance (SciTools#5653) ruff ICN rule compliance (SciTools#5652) ruff EXE rule compliance (SciTools#5651) ruff com rule compliance (SciTools#5650) Remove compliant ignored ruff rules (SciTools#5649) fix for ruff rule D301 (SciTools#5646) Updated environment lockfiles (SciTools#5645) Bump scitools/workflows from 2023.10.0 to 2023.12.1 (SciTools#5648)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This pull-request removes the
ruffrules that we temporarilyignore, but are already compliant with.Consult Iris pull request check list