Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nep29: drop py37 support #4481

Merged
merged 2 commits into from
Jan 10, 2022
Merged

nep29: drop py37 support #4481

merged 2 commits into from
Jan 10, 2022

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Jan 7, 2022

🚀 Pull Request

Description

This PR drops support for py37 as per the NEP29 backwards compatibility and deprecation policy support schedule.

Also see Python endoflife.


Consult Iris pull request check list

docs/src/whatsnew/latest.rst Outdated Show resolved Hide resolved
@rcomer
Copy link
Member

rcomer commented Jan 8, 2022

Do you need to remove the lockfile too, or will the action tidy that up?

@bjlittle
Copy link
Member Author

bjlittle commented Jan 8, 2022

Do you need to remove the lockfile too, or will the action tidy that up?

@rcomer The fix for the latest nox.lock and numpy 1.22 failure will be in a following PR 👍

@rcomer
Copy link
Member

rcomer commented Jan 8, 2022

Do you need to remove the lockfile too, or will the action tidy that up?

@rcomer The fix for the latest nox.lock and numpy 1.22 failure will be in a following PR 👍

Yep, the numpy change affects the py38 tests and so I agree is a separate issue. But we also have a py37 lockfile that this PR makes redundant.

@rcomer
Copy link
Member

rcomer commented Jan 8, 2022

Another line here 👀

https://github.com/bjlittle/iris/blob/583b759a2885c8cb9977e3b57ad62c512c7d472e/.github/workflows/refresh-lockfiles.yml#L74

@bjlittle
Copy link
Member Author

bjlittle commented Jan 10, 2022

@SciTools/iris-devs I'm keen to get this banked... any takers?

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @rcomer did all the work !

@pp-mo pp-mo merged commit 34ee90a into SciTools:main Jan 10, 2022
@zklaus
Copy link
Contributor

zklaus commented Jan 10, 2022

Heads up, @ESMValGroup/esmvaltool-coreteam.

@bjlittle bjlittle deleted the nep29-drop-py37 branch January 11, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants