address np printoptions pre/post v1.22 #4486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR addresses the test failures within #4480 when updating to the latest
numpy
v1.22.0.We've now dropped support within
iris
forpy37
(#4481) but we still require to supportnumpy
>= v1.19 (NEP29 Support Table). However numpy/numpy#19686 introduced a change that impactsiris.util.format_array
due to our use of the internalnumpy.core.arrayprint._formatArray
function.This PR maintains our continuing
numpy
v1.13 legacy array printing format forpy38
andnumpy
>= 1.19.As a separate concern, it would be wise to commit to addressing #3048, by at least bumping to the more recent
numpy
v1.21 legacy array printing.Consult Iris pull request check list