Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates Integrals.jl to the new interface in SciMLBase v2, and needs SciML/SciMLBase.jl#535 before merging.
It is a big rewrite since all of the calls to the algorithms needed to be rewritten to use the new interface correctly. And the deprecated interface still works! (There may be an edge case when the user specifies
nout=1
, but otherwise I checked all the old tests pass.)This pr also improves how the IntegralsCuba.jl and IntegralsCubature.jl packages call the C-libraries so that the integrand can use arrays of any shape.
The AD was also updated to the new interface, including a bugfix for nested forward-mode AD, and there are opportunities to extend this pr by adding user-provided jacobians to
IntegralFunction
andBatchIntegralFunction
.This pr may fix many of the open issues. I think it addresses the following:
#169
#186
#164
#67
#86
#76
#40
And possibly others.
This should get the main branch up and running again.