Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface error for VEGAS from [email protected] #193

Closed
lxvm opened this issue Nov 3, 2023 · 0 comments · Fixed by #195
Closed

Interface error for VEGAS from [email protected] #193

lxvm opened this issue Nov 3, 2023 · 0 comments · Fixed by #195

Comments

@lxvm
Copy link
Collaborator

lxvm commented Nov 3, 2023

The following mwe (taken from #46)

using Integrals, ForwardDiff, FiniteDiff, Zygote, Cuba

f(x,p) = sum(sin.(x .* p))
lb = ones(2)
ub = 3ones(2)
p = [1.5,2.0]
prob = IntegralProblem(f,lb,ub,p)
solve(prob,VEGAS(),reltol=1e-6,abstol=1e-6,maxiters =1000)[1]

errors with

ERROR: MethodError: no method matching iterate(::MonteCarloIntegration.VEGASResult{Float64, Float64, Float64, Matrix{Float64}, Matrix{Float64}})

however it works for [email protected].
We probably have to fix/revert commit 68ae9d6 from #189.
The tests didn't catch this because they opt out of VEGAS, which probably needs to change.

We could also look into replacing the package with the more capable https://github.com/numericalEFT/MCIntegration.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant