Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Extension points break the outline tree sync for apps with UI5 version =< 1.96.33 #2131

Merged
merged 20 commits into from
Jul 18, 2024

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Jul 8, 2024

Fix for #2130.

  • Add default values for created control and default content.

@nikmace nikmace added bug Something isn't working preview-middleware @sap-ux/preview-middleware preview-middleware-client labels Jul 8, 2024
@nikmace nikmace self-assigned this Jul 8, 2024
@nikmace nikmace requested a review from a team as a code owner July 8, 2024 10:06
Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 8a9f45e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from fix/2121/missing-scenario-api to main July 8, 2024 13:21
@mmilko01 mmilko01 requested a review from a team as a code owner July 8, 2024 13:21
Copy link
Contributor

@marufrasully marufrasully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikmace
The code change is easy and straight forward. Approve from my side.

Copy link
Contributor

@GDamyanov GDamyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Excellent test coverage.
Did not tested manually

Copy link

sonarcloud bot commented Jul 18, 2024

@nikmace nikmace merged commit 90a8291 into main Jul 18, 2024
13 checks passed
@nikmace nikmace deleted the fix/2130/outline-breaking-ext-points branch July 18, 2024 06:20
devinea added a commit that referenced this pull request Jul 22, 2024
…componentUsage

* origin/main: (62 commits)
  chore: apply latest changesets
  tbi(ui5-info): includeMaintained and includeDefault combination finds the next maintained version (#2166)
  chore: apply latest changesets
  fix: cds formatting issue when deleting properties (#2178)
  chore: apply latest changesets
  fix: storybook issue after storybook update (#2180)
  fix: failing test (#2182)
  chore: apply latest changesets
  Performance/project access/cache global cds module promise (#2148)
  chore: apply latest changesets
  feat: Add Adaptation Projects' Add Annotations To OData generator prompting (#2083)
  chore: apply latest changesets
  fix: consolidates multiple export functions into a single function applyCAPUpdates (#2168)
  chore: apply latest changesets
  feature(odata-service-inquirer): Adds abap on prem prompts (#2096)
  chore: apply latest changesets
  feat(axios-extension): add support for adap cds view service generation (#2157)
  chore: apply latest changesets
  fix: Extension points break the outline tree sync for apps with UI5 version =< 1.96.33 (#2131)
  chore: apply latest changesets
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview-middleware @sap-ux/preview-middleware preview-middleware-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants