-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Extension points break the outline tree sync for apps with UI5 version =< 1.96.33 #2131
Conversation
…P/open-ux-tools into fix/2121/missing-scenario-api
…P/open-ux-tools into fix/2121/missing-scenario-api
🦋 Changeset detectedLatest commit: 8a9f45e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nikmace
The code change is easy and straight forward. Approve from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
Excellent test coverage.
Did not tested manually
Quality Gate passedIssues Measures |
…componentUsage * origin/main: (62 commits) chore: apply latest changesets tbi(ui5-info): includeMaintained and includeDefault combination finds the next maintained version (#2166) chore: apply latest changesets fix: cds formatting issue when deleting properties (#2178) chore: apply latest changesets fix: storybook issue after storybook update (#2180) fix: failing test (#2182) chore: apply latest changesets Performance/project access/cache global cds module promise (#2148) chore: apply latest changesets feat: Add Adaptation Projects' Add Annotations To OData generator prompting (#2083) chore: apply latest changesets fix: consolidates multiple export functions into a single function applyCAPUpdates (#2168) chore: apply latest changesets feature(odata-service-inquirer): Adds abap on prem prompts (#2096) chore: apply latest changesets feat(axios-extension): add support for adap cds view service generation (#2157) chore: apply latest changesets fix: Extension points break the outline tree sync for apps with UI5 version =< 1.96.33 (#2131) chore: apply latest changesets ...
Fix for #2130.