-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(odata-service-inquirer): Adds abap on prem prompts #2096
Conversation
🦋 Changeset detectedLatest commit: 3325c31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
'origin/feat/2094/adds_abap_on_prem_prompts' into 210624
Back to draft, will add option to control prompting specifically for ADP use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small typos and queries
packages/odata-service-inquirer/src/translations/odata-service-inquirer.i18n.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Cian Morrin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New logic looks good for abap on prem prompts
Comments and questions addressed
Have not tested
Changeset
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks clean and covered by tests.
changeset ✅
haven't tested locally.
…componentUsage * origin/main: (62 commits) chore: apply latest changesets tbi(ui5-info): includeMaintained and includeDefault combination finds the next maintained version (#2166) chore: apply latest changesets fix: cds formatting issue when deleting properties (#2178) chore: apply latest changesets fix: storybook issue after storybook update (#2180) fix: failing test (#2182) chore: apply latest changesets Performance/project access/cache global cds module promise (#2148) chore: apply latest changesets feat: Add Adaptation Projects' Add Annotations To OData generator prompting (#2083) chore: apply latest changesets fix: consolidates multiple export functions into a single function applyCAPUpdates (#2168) chore: apply latest changesets feature(odata-service-inquirer): Adds abap on prem prompts (#2096) chore: apply latest changesets feat(axios-extension): add support for adap cds view service generation (#2157) chore: apply latest changesets fix: Extension points break the outline tree sync for apps with UI5 version =< 1.96.33 (#2131) chore: apply latest changesets ...
#2094