Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(odata-service-inquirer): Adds abap on prem prompts #2096

Merged
merged 53 commits into from
Jul 18, 2024

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Jun 28, 2024

#2094

  • Adds Abap on prem prompts

Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 3325c31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@sap-ux/odata-service-inquirer Minor
@sap-ux/project-input-validator Patch
@sap-ux/inquirer-common Patch
@sap-ux/cap-config-writer Patch
@sap-ux/deploy-tooling Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/adp-tooling Patch
@sap-ux/create Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/preview-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IainSAP IainSAP changed the title Feat/2094/adds abap on prem prompts feature(odata-service-inquirer): Adds abap on prem prompts Jun 28, 2024
@IainSAP IainSAP self-assigned this Jun 28, 2024
@IainSAP IainSAP marked this pull request as ready for review July 15, 2024 16:12
@IainSAP IainSAP marked this pull request as draft July 16, 2024 12:34
@IainSAP
Copy link
Contributor Author

IainSAP commented Jul 16, 2024

Back to draft, will add option to control prompting specifically for ADP use cases.

@IainSAP IainSAP added the odata-service-inquirer @sap-ux/odata-service-inquirer label Jul 16, 2024
@IainSAP IainSAP marked this pull request as ready for review July 16, 2024 18:17
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small typos and queries

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New logic looks good for abap on prem prompts
Comments and questions addressed
Have not tested
Changeset

Copy link

sonarcloud bot commented Jul 18, 2024

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks clean and covered by tests.
changeset ✅
haven't tested locally.

@IainSAP IainSAP merged commit 108336f into main Jul 18, 2024
13 checks passed
@IainSAP IainSAP deleted the feat/2094/adds_abap_on_prem_prompts branch July 18, 2024 11:40
devinea added a commit that referenced this pull request Jul 22, 2024
…componentUsage

* origin/main: (62 commits)
  chore: apply latest changesets
  tbi(ui5-info): includeMaintained and includeDefault combination finds the next maintained version (#2166)
  chore: apply latest changesets
  fix: cds formatting issue when deleting properties (#2178)
  chore: apply latest changesets
  fix: storybook issue after storybook update (#2180)
  fix: failing test (#2182)
  chore: apply latest changesets
  Performance/project access/cache global cds module promise (#2148)
  chore: apply latest changesets
  feat: Add Adaptation Projects' Add Annotations To OData generator prompting (#2083)
  chore: apply latest changesets
  fix: consolidates multiple export functions into a single function applyCAPUpdates (#2168)
  chore: apply latest changesets
  feature(odata-service-inquirer): Adds abap on prem prompts (#2096)
  chore: apply latest changesets
  feat(axios-extension): add support for adap cds view service generation (#2157)
  chore: apply latest changesets
  fix: Extension points break the outline tree sync for apps with UI5 version =< 1.96.33 (#2131)
  chore: apply latest changesets
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
odata-service-inquirer @sap-ux/odata-service-inquirer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants