Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing launch text for Cap projects to generate README files #2043

Merged
merged 16 commits into from
Jun 26, 2024
Merged

Add support for passing launch text for Cap projects to generate README files #2043

merged 16 commits into from
Jun 26, 2024

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Jun 17, 2024

#2019

Add support to dynamically generate launch text for Cap projects in cap-config-writers

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8f0fe36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/cap-config-writer Minor
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review June 17, 2024 16:15
@kjose90 kjose90 mentioned this pull request Jun 17, 2024
Open
4 tasks
@kjose90 kjose90 requested a review from a team as a code owner June 19, 2024 12:51
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Jun 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

devinea
devinea previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes and tests look good.
Patchset ✅

packages/cap-config-writer/src/cap-writer/utils.ts Outdated Show resolved Hide resolved
@kjose90 kjose90 requested a review from IainSAP June 24, 2024 10:54
IainSAP
IainSAP reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming/comments comments

packages/cap-config-writer/src/cap-writer/utils.ts Outdated Show resolved Hide resolved
packages/cap-config-writer/src/cap-writer/utils.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kjose90 kjose90 requested a review from IainSAP June 26, 2024 09:01
IainSAP
IainSAP approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjose90

  • Tests added to cover new utility functions

@kjose90 kjose90 requested a review from devinea June 26, 2024 09:17
devinea
devinea approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are clear and covered by tests
changeset - ok, patch would probably suffice here.
Thanks

@devinea devinea removed the request for review from a team June 26, 2024 10:27
@kjose90
Copy link
Member Author

kjose90 commented Jun 26, 2024

Thanks every one for reviewing

@kjose90 kjose90 merged commit 200894d into main Jun 26, 2024
13 checks passed
@kjose90 kjose90 deleted the cap-config-launchText branch June 26, 2024 10:30
@kjose90 kjose90 mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinea devinea devinea approved these changes

@IainSAP IainSAP IainSAP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kjose90 @devinea @IainSAP