Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generate readme functionalities to fiori generator shared #2022

Merged
merged 68 commits into from
Jun 26, 2024
Merged

Add generate readme functionalities to fiori generator shared #2022

merged 68 commits into from
Jun 26, 2024

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Jun 7, 2024 •
edited
Loading

#2019

  • Added generate read me logic to fiori-generator-shared

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 08b0ba8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-generator-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review June 13, 2024 13:45
@kjose90 kjose90 requested a review from a team as a code owner June 13, 2024 13:45
IainSAP
IainSAP requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code being added is not correct outside of tools-suite modules.

cianmSAP
cianmSAP previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition to fiori-generaot-shared looks good
Comments address
Excellent test coverage
Changeset ✅
Did not test locally but tests look good

@kjose90 kjose90 requested a review from IainSAP June 26, 2024 09:01
IainSAP
IainSAP previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjose90

  • Well defined interface to generate readme
  • Tests to cover

@kjose90 kjose90 requested a review from devinea June 26, 2024 12:21
devinea
devinea approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

IainSAP
IainSAP approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

  • Agreed to use file snapshot matchers in future

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kjose90 kjose90 merged commit 3b79570 into main Jun 26, 2024
13 checks passed
@kjose90 kjose90 deleted the cap-config-readme-os branch June 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinea devinea devinea approved these changes

@IainSAP IainSAP IainSAP approved these changes

@cianmSAP cianmSAP cianmSAP left review comments

Assignees

@kjose90 kjose90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kjose90 @devinea @IainSAP @cianmSAP