Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the parameter type to be EdmxAnnotationInfo for getAnnotationNamespace function #2024

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Jun 10, 2024

#1994

Addressing comment

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 2a06904

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux/odata-service-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 changed the title Adding type guard for handling both CDS and EDMX annotation information Change the parameter type to be EdmxAnnotationInfo for getAnnotationNamespace function Jun 10, 2024
@kjose90 kjose90 marked this pull request as ready for review June 10, 2024 14:32
@kjose90 kjose90 requested review from a team as code owners June 10, 2024 14:32
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactoring looks good.
changeset ✅

Copy link

sonarcloud bot commented Jun 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants