To support the exclusion of annotations from manifest json for cap projects #1994
Conversation
🦋 Changeset detectedLatest commit: 5003513 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -13,15 +13,17 @@ import type { NamespaceAlias, OdataService } from '../types'; | |||
| export function getAnnotationNamespaces({ metadata, annotations }: Partial<OdataService>): NamespaceAlias[] { | |||
| // Enhance service with annotations namespaces | |||
| const schemaNamespaces = metadata ? getNamespaces(metadata) : []; | |||
|
|
|||
| if (annotations?.xml) { | |||
| const edmxAnnotations = annotations as EdmxAnnotationsInfo; | |||
There was a problem hiding this comment.
Should we not test for the property of EdmxAnnotationsInfo before casting to that type?
| const edmxAnnotations = annotations as EdmxAnnotationsInfo; | |
| if (edmxAnnotations?.xml) { | |
| const edmxAnnotations = annotations as EdmxAnnotationsInfo; |
There was a problem hiding this comment.
getAnnotationNamespaces is called only if service is edmx so I think its okay?
There was a problem hiding this comment.
But thats not relevant within the context of the function. Please update to cast after determining the type. I think that makes more logically sense.
There was a problem hiding this comment.
Or better still change the parameter type to be EdmxAnnotationInfo if that is what should be passed to this function.
….com/SAP/open-ux-tools into refactor/move-cds-to-service-writers
|
|
Thanks for reviewing everyone |
#1949
fiori-elements-writer:Update fiori-elements-writer to not append local annotation names to FE service if the service type is CDS.
odata-service-writerAdd logic for writing annotation CDS files to the odata-service-writer module. If the service type is CDS and annotations are provided, write the annotations into the CDS file.-
OdataServiceannotation feature to accommodate both EDMX and CAP interfaces.