Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: request controller and model functions #2017

Merged
merged 4 commits into from
May 4, 2024
Merged

REFACTOR: request controller and model functions #2017

merged 4 commits into from
May 4, 2024

Conversation

sahsisunny
Copy link
Member

@sahsisunny sahsisunny commented Apr 21, 2024 •
edited
Loading

Issue Ticket Number

Description

Refactor request controller and model functions to add more request types, such as extension requests and task creation requests in the future.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

File Branch Coverage (%) Function Coverage (%) Statement Coverage (%) Line Coverage (%) Missing Lines
models/requests.ts 86.31 89.74 100 85.05 50-151,180-181
controller/oooRequests.ts 85 78.57 100 83.33 20,52-53
controller/requests.ts 84.61 70 100 83.33 30-136,146-147

Additional Notes

@sahsisunny sahsisunny marked this pull request as ready for review April 30, 2024 22:43
@sahsisunny sahsisunny mentioned this pull request May 4, 2024
Merged
10 tasks
iamitprakash
iamitprakash previously approved these changes May 4, 2024
View reviewed changes
@sahsisunny
Added middleware for extension request for /request route (#2028)
e5de75c 
* added middleware for extension request

* test: fix failing tests

* test: add types for res and req and remove consoles
@iamitprakash iamitprakash merged commit f97416b into develop May 4, 2024
2 checks passed
@iamitprakash iamitprakash deleted the refactor/requests-controllers branch May 4, 2024 17:17
@sahsisunny sahsisunny mentioned this pull request May 5, 2024
Merged
10 tasks
@somu-code somu-code mentioned this pull request May 16, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamitprakash iamitprakash iamitprakash left review comments

@Achintya-Chatterjee Achintya-Chatterjee Awaiting requested review from Achintya-Chatterjee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sahsisunny @iamitprakash