Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added middleware for extension request for /request route #2028

Merged

Conversation

sahsisunny
Copy link
Member

@sahsisunny sahsisunny commented Apr 30, 2024

Issue Ticket Number

Description

In the PR, a new middleware was added to create extension requests through the request router. This middleware will facilitate the creation of extension requests for the user.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

image

image

Test Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
extensionRequestsv2.ts 100 100 100 100
requests.ts 87.75 44.44 100 85.71 18,27-30,50,59

Additional Notes

In the next PR, a controller will be added to handle the extension request creation.

@sahsisunny sahsisunny changed the title added middleware for extension request Added middleware for extension request for /request route May 1, 2024
@sahsisunny sahsisunny marked this pull request as ready for review May 1, 2024 03:08
Copy link
Contributor

@tejaskh3 tejaskh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamitprakash iamitprakash merged commit e5de75c into refactor/requests-controllers May 4, 2024
1 check passed
@iamitprakash iamitprakash deleted the middleware/er-in-rewuest branch May 4, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants