Added "-" in validation for generating username

middlewares/validators/user.js

@@ -22,7 +22,7 @@ const updateUser = async (req, res, next) => {
  .optional()
  .min(4)
  .max(20)
- .regex(/^[a-zA-Z0-9]+$/)
+ .regex(/^[a-zA-Z0-9-]+$/)
  .message("Username must be between 4 and 20 characters long and contain only letters or numbers."),
  first_name: joi.string().optional(),
  last_name: joi.string().optional(),

test/unit/middlewares/user-validator.test.js

@@ -262,6 +262,49 @@ describe("Middleware | Validators | User", function () {
  });
  expect(nextSpy.calledOnce).to.be.equal(false);
  });
+ it("Allows a valid username", async function () {
+ const req = {
+ body: {
+ username: "john-doe",
+ },
+ };
+
+ const res = {
+ boom: {
+ badRequest: (message) => {
+ throw new Error(message);
+ },
+ },
+ };
+
+ const next = sinon.spy();
+
+ await updateUser(req, res, next);
+
+ expect(next.calledOnce).to.be.equal(true);
+ });
+
+ it("Stops the propagation of next for an invalid username", async function () {
+ const req = {
+ body: {
+ username: "@john_doe",
+ },
+ };
+
+ const res = {
+ boom: {
+ badRequest: () => {},
+ },
+ };
+
+ const nextSpy = sinon.spy();
+
+ await updateUser(req, res, nextSpy).catch((err) => {
+ expect(err).to.be.an.instanceOf(Error);
+ });
+
+ expect(nextSpy.calledOnce).to.be.equal(false);
+ });
  });
 
  describe("Create user validator for getUsers", function () {