Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "-" in validation for generating username #1660

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

vinit717
Copy link
Member

@vinit717 vinit717 commented Nov 2, 2023

Developer Name: @vinit717

Issue Ticket Number:- #1661

Description
Added "-" in regex to validate the username and write its test case

Backend changes

  • Yes
  • No

Frontend Changes

  • Yes
  • No

Is Under the Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Deployment notes
Any special instructions for the deployment (none)

Tested in staging

  • Yes
  • No

Before Changes:
image

After Changes:
image

Test Stats:
image

@vinit717 vinit717 self-assigned this Nov 2, 2023
Copy link

@samyakshah3008 samyakshah3008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@prakashchoudhary07 prakashchoudhary07 merged commit 38fd290 into develop Nov 2, 2023
3 checks passed
@prakashchoudhary07 prakashchoudhary07 deleted the fix/validate-username branch November 2, 2023 13:27
@sahsisunny sahsisunny mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants