Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp/phytium]中断相关修改 #8742

Merged
merged 12 commits into from
Apr 10, 2024
Merged

Conversation

messigogogo
Copy link
Contributor

@messigogogo messigogogo commented Apr 8, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#8563 问题

你的解决方案是什么 (what is your solution)

不易从内核中修改,因此对[bsp/phytium]中断初始化函数做了适配。仿照libcpu中其他架构,修改aarch64部分内容。主要是将宏定义放在了.h文件中(其他架构也放在.h中,这里参考进行了移动),添加接口获取_gic_table基地址。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@messigogogo
Copy link
Contributor Author

messigogogo commented Apr 8, 2024

这个静态检查的错误是什么意思?“=”两边的值没有检测出来吗?

@mysterywolf
Copy link
Member

如果静态检查报错来的错误是认定没问题的 请无视 有的时候会误报

@mysterywolf mysterywolf requested review from BernardXiong and polarvid and removed request for BernardXiong April 10, 2024 00:24
@BernardXiong BernardXiong merged commit 81df7bc into RT-Thread:master Apr 10, 2024
40 of 41 checks passed
mysterywolf pushed a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants