Support hipModuleLaunchKernel API if the kernelParams are not null. #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the kernel argument layout from the metadata. This enables a PyTorch use case of this API. While there, add some items to gitignore.
|
@gargrahul looks like it built correctly? what am I missing? |
|
@iotamudelta This PR touches program_state and hip_module. I'd like to let you know that we are trying to move most of the data structures and logic in program_state from the header into HIP's runtime shared library with #1077. We are almost ready to merge #1077 so it looks like there will be a couple of minor changes needed to adapt this PR to #1077. |
|
@iotamudelta PR #1077 has been merged. Please rebase and resolve the conflicts in this PR. |
|
Overcome by events - #1097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the kernel argument layout from the metadata.
This enables an important PyTorch use case of this API.
While there, add some items to gitignore.