migrate program_state logic from header into shared library (phase I) #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-merging PR991 against other program state changes
This avoids program state reloading executables after a shared library is dlopened. re-merging PR1057 against other program state changes
|
@jeffdaily could you review? I wasn't able to add you as a reviewer... |
jeffdaily
reviewed
May 8, 2019
mangupta
approved these changes
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ongoing effort to migrate device code management logic introduced in PR#929 from header files into the HIP runtime shared library while maintaining the same functionality. This would reduce a significant amount of symbols in the application objects and minimize exposure of HIP's internal data structures to hazardous environments.
This PR includes functionalities in #1057 adapted by @jeffdaily
This PR should be merged before #1067 , which needs to be updated to adapted to this PR and will be submitted in a future PR.