-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pinned requirements #2709
Conversation
Thank you for submitting a pull request (PR) to PlasmaPy! ✨ The future of the project depends on contributors like you, so we deeply appreciate it! 🌱 Our contributor guide has information on:
Important PlasmaPy recently switched to an The bottom of this page shows several checks that are run for every PR. Don't worry if something broke! We break stuff all the time. 😺 Click on "Details" to learn why a check didn't pass. Please also feel free to ask for help. We do that all the time as well. 🌸 You can find us in our chat room or weekly community meeting & office hours. Here are some tips:
If this PR is marked as ready for review, someone should stop by to provide a code review and offer suggestions soon. ✅ If you don't get a review within a few days, please feel free to send us a reminder. Please also use SI units within PlasmaPy, except when there is strong justification otherwise or in some examples. We thank you once again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 104 104
Lines 9435 9435
Branches 2167 2167
=======================================
Hits 8986 8986
Misses 272 272
Partials 177 177 ☔ View full report in Codecov by Sentry. |
@pheuer should we try just increasing the timeout to something like 40 seconds?? |
Sure, we could try that: it really should respond faster than that. Another option would be to have a fixture that checks connection to that address, then use pytest skip to skip these tests if the connection isn't working? |
Thanks for following up on the intermittent failure in #2710! I re-ran the Python 3.10 lowest-direct tests, and I'll merge this PR since it passed. |
Also there are more updates here because I loosened some Jupyter ecosystem requirements in #2705 for Google Colab compatibility (sigh). |
This pull request (PR) regenerates the pinned requirements files used in continuous integration (CI) tests and by integrated development environments (IDEs), including requirements.txt and the files in therequirements/ directory. To update requirements locally, run "tox -e requirements", with the environment defined in tox.ini. The resolution of requirements is done by uv.
The purpose of periodically regenerating requirements files is to reduce the probability that tests will spontaneously start failing in other PRs due to a breaking change in a dependency. If all tests pass, please merge this PR. If any checks fail due to changes in the packages that we depend on, please use this PR to perform the fixes that are necessary to get the checks to pass again.
In some cases, it may be necessary to put a temporary upper limit on the allowed versions of a dependency as defined in pyproject.toml. If this is necessary, please create an issue that this upper limit should be removed.