Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen dependencies on ipykernel, ipywidgets, and voila ⬇️ #2705

Merged
merged 2 commits into from
May 30, 2024

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented May 29, 2024

This PR loosens requirements on ipykernel, ipywidgets, and voila to be consistent with what is used by Google Colab, which is currently v5.5.6. See #2655 the motivation why.

We should strive to keep the minimum version of ipykernel to be no greater than the version used by Google Colab (which tends to run older versions of a bunch of packages, and also Python).

@github-actions github-actions bot added requirements Related to updating requirements packaging Related to packaging or distribution labels May 29, 2024
@namurphy
Copy link
Member Author

namurphy commented May 29, 2024

Got this error:

 Traceback (most recent call last):
  File "D:\a\PlasmaPy\PlasmaPy\.nox\tests-3-10-lowest-direct\lib\site-packages\_pytest\config\__init__.py", line 802, in import_plugin
    __import__(importspec)
ModuleNotFoundError: No module named 'pytest_tornasync'

Related to voila-dashboards/voila#728; will bump the voila requirement to after this was resolved.

@namurphy namurphy marked this pull request as draft May 29, 2024 23:29
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (e4b3847) to head (0505118).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2705   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         104      104           
  Lines        9399     9399           
  Branches     2155     2155           
=======================================
  Hits         8951     8951           
  Misses        272      272           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namurphy namurphy marked this pull request as ready for review May 30, 2024 00:18
@namurphy namurphy merged commit 5a39092 into PlasmaPy:main May 30, 2024
18 checks passed
@namurphy namurphy deleted the loosen-ipykernel branch May 30, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Related to packaging or distribution requirements Related to updating requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant