Add PCLZIP alternative to ZipArchive (merged from #140) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake it work with the latest develop branch
…ake it work with the latest develop branch
…PHPWord into PHPOffice#140-bskrtich-pclzip
|
Thank you @ivanlanin, I have been knocked on my ass with the flu and I havnt been able to work on this at all. |
|
For what its worth, your code looks good to me |
|
Great. If there's no other input from the team, we'll merge this pull. Flu is really annoying and can make you unable to do anything. Have you fully recovered now? |
|
@PHPOffice/phpword-team This pull is already save to merge and has passed Travis tests. Any feedback/consideration? If none, I'll merge and close other related issues. Thanks. |
ivanlanin
added a commit
that referenced
this pull request
Mar 30, 2014
Add PCLZIP alternative to ZipArchive (merge and close #140)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've merged #140 from @bskrtich with the latest version of develop branch and added some unit tests. I agree with him that it would be nice to be able to use PHPWord without needing ZipArchive. Please review.