-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to use PHPWord with out ZipArchive #106
Comments
I hope to be able to work on this some time this week. |
Fortunately, all servers that I've been dealing with provide php_zip. But, I since the tag line of PHPWord is a pure PHP library for reading and writing Word files, I think it will be good if we can also use a pure PHP compression utility :) |
Yea, all of our servers dont have php_zip, so I had to hack in an alternative. Its very nice to not have PHPWord dependent on php_zip. |
I consider myself lucky, then :) By the way, I think we should put the php_zip requirement in the README. |
@bskrtich If you want PHPExcel use PCLZip for ZipEngine (https://github.com/PHPOffice/PHPExcel/tree/develop/Classes/PHPExcel/Shared/PCLZip). But the best part in PHPExcel is the opportunity of change the ZIP Engine : |
I think |
@ivanlanin Affirmative :) |
FYI I started on this already and I hope to have it done tomorrow. |
Wow. Cool! Please create some unit tests for that since we're very close to 100% code coverage :) Travis said we're 91.31% now (4687/5133). |
Ok the main code is done. Does someone mind doing a sanity check on my code before I write the unit tests for this? |
I'll check. |
I've submitted a pull request. Please review. |
@bskrtich, how could it be so? Which OS and which PHP version do you use? |
it would be nice to be able to use PHPWord with out needing ZipArchive. PHPExcel does this by using the PCLZip library.
The text was updated successfully, but these errors were encountered: