Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use PHPWord with out ZipArchive #106

Closed
hskrtich opened this issue Mar 11, 2014 · 14 comments · Fixed by #140
Closed

Ability to use PHPWord with out ZipArchive #106

hskrtich opened this issue Mar 11, 2014 · 14 comments · Fixed by #140
Assignees
Milestone

Comments

@hskrtich
Copy link
Contributor

it would be nice to be able to use PHPWord with out needing ZipArchive. PHPExcel does this by using the PCLZip library.

@hskrtich
Copy link
Contributor Author

I hope to be able to work on this some time this week.

@ivanlanin
Copy link
Contributor

Fortunately, all servers that I've been dealing with provide php_zip. But, I since the tag line of PHPWord is a pure PHP library for reading and writing Word files, I think it will be good if we can also use a pure PHP compression utility :)

@hskrtich
Copy link
Contributor Author

Yea, all of our servers dont have php_zip, so I had to hack in an alternative. Its very nice to not have PHPWord dependent on php_zip.

@ivanlanin
Copy link
Contributor

I consider myself lucky, then :) By the way, I think we should put the php_zip requirement in the README.

@Progi1984
Copy link
Member

@ivanlanin
Copy link
Contributor

I think PHPWord\Settings is also where we should put the setting for #103 :)

@Progi1984
Copy link
Member

@ivanlanin Affirmative :)

@Progi1984 Progi1984 added this to the 0.7.3 milestone Mar 13, 2014
@hskrtich
Copy link
Contributor Author

FYI I started on this already and I hope to have it done tomorrow.

@ivanlanin
Copy link
Contributor

Wow. Cool! Please create some unit tests for that since we're very close to 100% code coverage :) Travis said we're 91.31% now (4687/5133).

@hskrtich
Copy link
Contributor Author

Ok the main code is done. Does someone mind doing a sanity check on my code before I write the unit tests for this?

@ivanlanin
Copy link
Contributor

I'll check.

@ivanlanin
Copy link
Contributor

I've submitted a pull request. Please review.

@ivanlanin
Copy link
Contributor

Resolved by #140 and #185 merge.

@Progi1984 Progi1984 added this to the 0.9.2 milestone Mar 31, 2014
@ghost
Copy link

ghost commented Jul 3, 2014

Yea, all of our servers dont have php_zip, so I had to hack in an alternative.

@bskrtich, how could it be so? Which OS and which PHP version do you use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants