Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Word2007 Reader to read images when pictures is between <wp:anchor> #1799

Closed
wants to merge 3 commits into from

Conversation

begnini
Copy link
Contributor

@begnini begnini commented Jan 6, 2020

Description

Word2007 Reader didn't read images where pictures was between wp:anchor, accepction only with wp:inline.

The OpenOffice XML docs says:

The XML for placement of the picture (e.g., whether it is inline [wp:inline] or anchored [wp:anchor]) is within the wordprocessing drawingML namespace: xmlns:wp="http:https://schemas.openxmlformats.org/drawingml/2006/wordprocessingDrawing".

Improved tests to be capable of read images from docs generated by AbstractTestReader::getDocumentFromString

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@begnini
Copy link
Contributor Author

begnini commented Jan 6, 2020

This solves the same problem pointed by PR #1794. The difference between the PRs is the tests I added.

@coveralls
Copy link

coveralls commented Jan 6, 2020

Coverage Status

Coverage increased (+0.009%) to 94.642% when pulling 6e463bb on begnini:better_image_reader into 733f845 on PHPOffice:develop.

@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:11
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@begnini begnini closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants