Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for "cloudConvert" images #1794

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Added support for "cloudConvert" images #1794

merged 1 commit into from
Jul 7, 2020

Conversation

ernst77
Copy link

@ernst77 ernst77 commented Jan 1, 2020

Description

Some online converters (e.g. CloudConvert) add images with different path than Office 2011.

Fixes # (issue)
If embed element not found I try to find element with different path

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 94.615% when pulling fa0ba2e on ErnestStaug:image_conversion_support into 733f845 on PHPOffice:develop.

@begnini begnini mentioned this pull request Jan 6, 2020
Closed
3 tasks
@ernst77 ernst77 mentioned this pull request May 9, 2020
Open
@troosan troosan added this to the v0.18.0 milestone Jul 7, 2020
@troosan troosan merged commit 21f4bb3 into PHPOffice:develop Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ernst77 @coveralls @troosan