add support wordwrap for paragraph #1688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troosan
reviewed
Sep 1, 2019
| * @see \PhpOffice\PhpWord\SimpleType\JcTable For table alignment modes available since ISO/IEC-29500:2008. | ||
| * @see http:https://www.datypic.com/sc/ooxml/t-w_ST_Jc.html | ||
| */ | ||
| final class WordWrap extends AbstractEnum |
There was a problem hiding this comment.
should be renamed to OnOff, see documentation http:https://www.datypic.com/sc/ooxml/t-w_ST_OnOff.html
troosan
reviewed
Sep 1, 2019
| /** | ||
| * @since 0.17.0 | ||
| */ | ||
| class ParagraphWordWrap |
There was a problem hiding this comment.
no need for this, WordWrap is just a simple on/off, there are no other attributes possible (see http:https://www.datypic.com/sc/ooxml/e-w_wordWrap-1.html)
There was a problem hiding this comment.
Sorry ,my English is not well ,so i have some trouble to talk with you ,but i think you can add the wordwrap future to phpword after you resolve it by yourself .
Implement a number of features implemented in PhpWord,
but not yet supported in PhpWord HTML Writer.
1. Use css @page and page declarations for sections.
2. Wrap sections in div, with page break before each (except first).
3. Add ability to specify generic fallback font for html (documentation change).
4. Add ability to specify handling of whitespace in html (documentation change).
Currently, Word writer preserves space but HTML writer does not.
5. Support for Language, both for document overall and individual text elements.
6. Support for PageBreak for HTML (currently only PDF is supported).
7. Support for Table Border style, color, and size.
8. Support for empty paragraphs (Word writer permits, browsers generally suppress).
9. Default paragraph style should apply to all paragraphs, as well as class Normal.
10. Paragraph style should support line-height.
11. Paragraph style should support indentation.
12. Paragraph style should support page-break-before.
13. Paragraph style should not specify margin-top/bottom when spacing is null.
Testing change from Pull Request 1771 is included here, but was
merged after my fork.
Mostly docblock changes, specifying that members can be null if so.
Hopefully this clears 3 remaining issues.
Reaction to Coveralls report.
I had been overriding some "false positive" Scrutinizer messages with annotations. Seeing if an alternate approach also works.
New issue after removing annotations.
Zend/Escaper is no longer maintained. However, everything that it does can be handled perfectly well by htmlspecialchars. This change removes the dependency on it, and changes code which used it. Also add additional tests. Coverage of Writer/HTML is now 100%
Scrutinizer reported a problem because Title->getText() was annotated to return a string, but it can actually return either a string or a TextTun.
Change one statement in Writer/HMTL/Title
See issue PHPOffice#1993. The code currently defines the same method twice; this edit fixes that.
This member was NOT part of my change, yet Travis failed my PR because of use of spaces on a blank line. Even though this is easy to correct, it seems very unreasonable (failing PR because of unchanged member).
Progi1984
force-pushed
the
master
branch
2 times, most recently
from
2d9f999
to
e458249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add support wordwrap for paragraph to fixes
#1687
Checklist:
composer run-script check --timeout=0and no errors were reported