-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in TCPDF after PR #1983 and #1907 #1993
Labels
Comments
I have added a fix for this in PR #1814. However, you may want to fast-track a more targeted solution. |
There was a fix today ("fix formatting" - I cannot find a PR number). It fixed the formatting error, but left both duplicate functions intact, so was ineffective. |
After a fix today ("fix merge issue" - no PR number), TCPDF.php is now in good shape. Closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
The code for src/PhpWord/Writer/PDF/TCPDF.php defines function createExternalWriterInstance twice, causing the test suite to fail. PR #1983 introduced the second copy of the function. PR #1907 is responsible for the first version of the function. The functions are identical, except for a formatting problem in 1907.
Steps to Reproduce
Please provide a code sample that reproduces the issue.
Running the test suite fails because one of the tests fails due to the duplicated function.
The test which fails is PhpOffice\PhpWord\Writer\PDF\TCPDFTest::testConstruct.
Expected Behavior
Test suite should pass.
Current Behavior
What is the current behavior?
Test suite fails.
Context
Please fill in your environment information:
The text was updated successfully, but these errors were encountered: