Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission to 0.7.1 #43

Closed
5 tasks done
Progi1984 opened this issue Dec 16, 2013 · 23 comments
Closed
5 tasks done

Mission to 0.7.1 #43

Progi1984 opened this issue Dec 16, 2013 · 23 comments
Assignees
Milestone

Comments

@Progi1984
Copy link
Member

@gabrielbull
Copy link
Member

Can we have these on the road to 0.8.0 instead of 0.7.1 so we can release small updates faster?

@Progi1984
Copy link
Member Author

@gabrielbull I keep it in the current milestone... If it's not finished while other tickets have been closed, I will change the milestone for this one.

@ghost
Copy link

ghost commented Feb 15, 2014

Hi, @Progi1984,
please, let me know when you finish with unit tests code reorganization. I will write unit tests for the feature described in issue #46 then.

Thanks.

@Progi1984
Copy link
Member Author

Hi @RomanSyroeshko , I just update the first post for moving tests directory.

@Progi1984 Progi1984 mentioned this issue Mar 3, 2014
12 tasks
@ivanlanin
Copy link
Contributor

I'm willing to help on the documentation and creating unit tests. I will start with unit tests since I can (almost) figure out what to do. But what about the documentation? How are we going to approach this? By using README like we have now?

@Progi1984
Copy link
Member Author

If you want, you can work on unit tests... I'm currently working on the Section directory. So you can work on another directory if you want.

@ghost
Copy link

ghost commented Mar 8, 2014

Unit tests on Template class are reserved by me. :)

@ivanlanin
Copy link
Contributor

Ok :) I'll start with Style

@ivanlanin
Copy link
Contributor

Hi @Progi1984

2: Implement unit tests on Travis CI: This is done, right?
3: Transform the red status in green status on Travis CI (https://travis-ci.org/PHPOffice/PHPWord): I don't think we can pass phpcs without implementing namespaces
4: Test and migrate all samples: Will do. That's from the samples/old folder right?
5: Create basic documentation with ReadTheDocs: How?

@gabrielbull
Copy link
Member

3: Transform the red status in green status on Travis CI

We can't, we need to push this one to the 0.8.0 milestone.

@ivanlanin
Copy link
Contributor

2: How much code coverage we want to achieve for 0.7.1? We're currently 66.2% (see image). Do we want to achieve 100%? I think 90% will be ok :)

2014-03-12-200436-ss

@Progi1984
Copy link
Member Author

@ivanlanin, @gabrielbull
2. The goal for 0.8.0 is 100%
3. Yeap, i know that but see this ticket (#43 (comment)) so when issues #74 & #19 will be closed, I will release PHPWord 0.7.1.
4. Yep...
5. I will begin a real documentation this week for improving it as in versions.

@ivanlanin
Copy link
Contributor

  1. Ok. So 100% is for 0.8
  2. Ok. Two more to go :)
  3. Ok. So migrating samples is not for 0.7.1 phew
  4. Let us I know how we can help for the documentation. We can use github wiki to start drafting if you want. That way, you're not working alone.

@gabrielbull
Copy link
Member

Let us I know how we can help for the documentation. We can use github wiki to start drafting if you want. That way, you're not working alone.

👍

@Progi1984
Copy link
Member Author

@ivanlanin @gabrielbull I begin the documentation this week... so don't worry ! I will ask you some help for really improving it.

@ivanlanin
Copy link
Contributor

Ok 👍
By the way, I just realize that we can use smiley! Thanks for pointing that out, @gabrielbull :)

@ghost
Copy link

ghost commented Mar 12, 2014

Guys, could somebody explain to me how to fork from develop branch?

I'm in a strange situation now. I dropped my old fork and recreated it from master branch. Then I decided to make some changes in the code. To do that I need actual code, so I made a pull request to pull changes from develop branch into my fork. Then I committed some changes to my fork. I would like to create a PR, but it suggest to merge to PHPWord's develop not only my changes, but merged from develop branch changes too.

Should I wait the moment when changes from develop branch will go to master and then try again, or there is another way?

@gabrielbull
Copy link
Member

After forking, clone on your local machine and use the command git checkout develop to work on the develop branch

@ghost
Copy link

ghost commented Mar 12, 2014

Got it! Thanks a lot, @gabrielbull.

@ivanlanin
Copy link
Contributor

@Progi1984 Number 4 (test and migrate all samples) done. We can delete samples/old if we want.

@Progi1984
Copy link
Member Author

@ivanlanin You can delete it in the PR #122

@gabrielbull
Copy link
Member

Can we close this one (Duplicate with #124 ) and move the unchecked tasks to #81 ?

@Progi1984 Progi1984 modified the milestone: 0.8.0 Mar 14, 2014
@Progi1984
Copy link
Member Author

Closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants