Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.8.0 #124

Closed
5 tasks done
Progi1984 opened this issue Mar 14, 2014 · 28 comments
Closed
5 tasks done

Release 0.8.0 #124

Progi1984 opened this issue Mar 14, 2014 · 28 comments
Milestone

Comments

@Progi1984
Copy link
Member

Before release 0.8.0, could you

  • 1 Test samples and test that the render is correct
  • 2 Test unit test and verify no errors
  • 3 Test PHPWord with your code and valid it
  • 4 Verify Changelog and verify that nothing has been forgotten
  • 5 Verify Readme.md and verify no errors

Link : https://github.com/PHPOffice/PHPWord/blob/develop/changelog.txt

CC : @gabrielbull (OK) @ivanlanin @RomanSyroeshko

@Progi1984 Progi1984 added this to the 0.7.1 milestone Mar 14, 2014
@ivanlanin
Copy link
Contributor

Will do number 4 and 5. I'm using PHPWord develop branch for production, so I always conduct point number 1 to 3. My users will scream out loud if I don't do that :)

@ghost
Copy link

ghost commented Mar 14, 2014

OK, I will doublecheck my changes today, or maybe tomorrow.

@gabrielbull
Copy link
Member

Ok, I changed the issue to 0.8.0.

I'm good to go with number 1 through 5.

👍

@gabrielbull gabrielbull mentioned this issue Mar 14, 2014
5 tasks
@ivanlanin
Copy link
Contributor

Since we're fastforwarding to 0.8, are we still going to achive 100% code coverage? Can we move the 100% to, say, 1.0? :)

We're now 86% (on my machine). Yay!

2014-03-14-221432-ss

@gabrielbull
Copy link
Member

Yes, objective 💯% has been pushed to milestone 0.9.0, we'll see if we can get it there :-)

#81

@ivanlanin
Copy link
Contributor

Great! 0.8 can be released sooner. We're going to achive 100% on 0.9. I'm sure! :)

@Progi1984
Copy link
Member Author

Yeap, I'm waiting for @RomanSyroeshko and its feedback, and the update of @bskrtich in #120. And I release the week-end :)

@gabrielbull
Copy link
Member

What are you using for coverage? I'm getting 96% files and 69% (hic!) lines coverage on PHPStorm.

image

@ivanlanin
Copy link
Contributor

I'm on Windows :) Here's mine:

2014-03-14-222715-ss

And here's from Travis:
Summary:
Classes: 43.24% (32/74)
Methods: 79.18% (483/610)
Lines: 85.64% (4436/5180)

@Progi1984
Copy link
Member Author

@gabrielbull I use the return of Travis-CI.
https://travis-ci.org/PHPOffice/PHPWord/jobs/20774093#L3249

@gabrielbull
Copy link
Member

Yeay, nobody has same coverage ;-)!

@ghost
Copy link

ghost commented Mar 14, 2014

Just to be on the same page. @Progi1984, I'm lost in version numbering. What's the next version will be after 0.7.1? It's 0.7.2, or 0.8.0, or what?

@gabrielbull
Copy link
Member

0.8.0 is next version !

See the draft: https://github.com/PHPOffice/PHPWord/releases

@ivanlanin
Copy link
Contributor

I added a "Feature" section in the README to attract people to use PHPWord. Feel free to add or revise the contents. I also updated the changelog.

@gabrielbull
Copy link
Member

Changelog needs to be reflected in the release draft: https://github.com/PHPOffice/PHPWord/releases

@ivanlanin
Copy link
Contributor

Ok. Will do.

@ivanlanin
Copy link
Contributor

@Progi1984 @gabrielbull I've done all the five todos, including updating the release draft. I'm off now. It's almost 3 a.m. here :)

@gabrielbull
Copy link
Member

Sleep well!

@ghost
Copy link

ghost commented Mar 15, 2014

Time: 57.74 seconds, Memory: 28.25Mb
There was 1 error:
1) PHPWord\Tests\Writer\Word2007Test::testSetGetUseDiskCaching
Undefined variable: phpWord
/home/travis/build/PHPOffice/PHPWord/Tests/PHPWord/Writer/Word2007Test.php:106
FAILURES!
Tests: 248, Assertions: 766, Errors: 1.

@ivanlanin, that's yours. ;)

@ivanlanin
Copy link
Contributor

Oh, my :( I'll fix it ASAP.

@ghost ghost mentioned this issue Mar 15, 2014
@ghost
Copy link

ghost commented Mar 15, 2014

@Progi1984, everything as expected on my side.

@ivanlanin
Copy link
Contributor

Code Coverage Report 2014-03-15 07:52:02

  • Classes: 47.30% (35/74)
  • Methods: 82.81% (501/605)
  • Lines: 90.16% (4645/5152)

Yay!

@Progi1984
Copy link
Member Author

Ok... I'll release, guys :)

@Progi1984
Copy link
Member Author

@ivanlanin
Copy link
Contributor

Woho! Congrats! On to 0.9!

@ivanlanin
Copy link
Contributor

So we're going straight to 0.9 (with tons of new features!) or we take small steps to 0.8.1, etc.?

@ghost
Copy link

ghost commented Mar 15, 2014

It will be 0.9.0, I guess. AFAIK, it's a common practice to increment the 3rd digit in case if you deliver fixes only, and to increment the 2nd digit if you deliver at least one new feature. So, if we're going to deliver some new features, it should be 0.9.0.

@gabrielbull
Copy link
Member

You can see the next planned versions and issues associated to these versions here: https://github.com/PHPOffice/PHPWord/issues/milestones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants