-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Requirments in the Readme #120
Comments
I've put the requirement for ZipArchive in the README. Where do we use libxml? CMIIW, I think we're using DOMDocument and SimpleXML. |
Looking at the code, it uses XMLWriter and XMLWriter requires libxml. So instead of libxml we should list XMLWriter. Also it would be a good idea to update composer.json with these requirements. |
Yup. You're right. So we should move ext-zip from recommend to require in composer.json? |
Yes until someone (maybe me) adds PCL ZIP support. |
PHPWord users will like it when you can't sleep ;) |
@ivanlanin @bskrtich Could you send a pull request for the readme.MD and the composer.json ? Thanks :) |
I think it is rather recommandations rather than requirements. Why ? Imagine a developer which only want to generate RTF Files and no ODT/DOCX files. |
For both zip & xml, correct? |
Yes... What do you think about that ? |
Sounds reasonable to me. I will make the change now. |
Yes, we don't need xml and zip for RTF. But, why would anyone use PHPWord (with the |
@ivanlanin I agree with you but in the future, I hope we support DOC file format which no needs XML & ZIP, like HTML, WPS or PDF. I think that the requirement for a writer/reader must be precised in the documentation |
Why not, @ivanlanin? |
Haha. Alright. I think we will have to make our RTF Writer better, then. |
@ivanlanin A good objective. Don't hesitate to create issues with missing features. |
@ivanlanin @RomanSyroeshko @bskrtich |
I admit that there's a possibility that people will use PHPWord only for creating RTFs, but I still think that most people will use PHPWord to create Word documents. RTF creation is an extra feature for us. So, I support @bskrtich pull request #121 |
On the one hand, I agree that "ext-zip" and "ext-xml" should be optional in common case. Our documentation should be clear enough about usage of the extensions. Users should understand what the extensions are used for, and when they should be enabled. On the other hand, at the current moment PHPWord works witn OOXML and ODT. These formats require ZIP and XML extensions. So, I suggest consider that XML and ZIP extensions are required for now, because it's true. I suggest to return to the discussion when we support some format which doesn't require XML or ZIP extension. By the way, we forgot two things.
P.S. |
@RomanSyroeshko @ivanlanin @bskrtich So :
What do you think about that ? |
Good idea. By the way, where did we get "ext-xml"? It seems PHP doesn't have such extension http:https://php.net/manual/en/extensions.membership.php. |
@RomanSyroeshko The package is php-xml. The doc is here : http:https://php.net/manual/en/xml.installation.php |
Agree. Wrap it up and on to 0.8! :) |
@Progi1984, OK. @ivanlanin, 0.7.2 first. :) |
@bskrtich Could you update your pull request, please ? |
@bskrtich Wake up and update your pull request, dude. We're going to release 0.8 :) |
@ivanlanin Yes sir! lol I will get the push updated in the next few min. |
Ok a new push is up. I think i did every thing right |
Thanks! 👍 |
Fixed in develop branch. |
Please update the requirement in the ReadMe to include:
PHP Extension ZipArchive
PHP Extension libxml
The text was updated successfully, but these errors were encountered: