-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change setIndent and setIndentString to be more compatible #103
Comments
LibreOffice doesn't report any problem. Removing lines reduces file size, but also reduces readability when studying the source file of the XML. Is it better to implement some kind of settings as (get/set) that people can use depending on their preferences (e.g. |
@ivanlanin I support your idea 😉 |
@ivanlanin I like the idea but I would propose that the default be false to be more compatible. |
I agree. After all, there will be more people using OpenOffice than tweaking the XML :) |
@ivanlanin Affirmative ! |
The files PHPWord create seem to be malformed for OpenOffice because PHPWord formats the xml with spaces and newlines. Word removes this lines and shows the document how its supposed to be, but OO inserts a newline for every newline in the xml-doc in the document is shows. Changing these line in Shared/XMLWriter.php fix this.
There is a comment in the code saying this might need to be turned off for production.
The text was updated successfully, but these errors were encountered: