Precip variability across time scales

[lee1043]

I am opening PR for the precip variabliity metric. @msahn, do you consider the branch is ready to be merged?

[lee1043]

@msahn I don't think demo notebook is included in this branch. I can not recall if we had one or not, could you please remind me?

[msahn]

@msahn I don't think demo notebook is included in this branch. I can not recall if we had one or not, could you please remind me?

Ana created the demo notebook for the precip variability at the branch below.
https://github.com/PCMDI/pcmdi_metrics/tree/731_ao_precip_benchmark_nb

[msahn]

I am opening PR for the precip variabliity metric. @msahn, do you consider the branch is ready to be merged?

Thank you. I think this branch will be ready after merging the branch you made for modifying code style.

[lee1043]

@msahn I don't think demo notebook is included in this branch. I can not recall if we had one or not, could you please remind me?

Ana created the demo notebook for the precip variability at the branch below. https://github.com/PCMDI/pcmdi_metrics/tree/731_ao_precip_benchmark_nb

@acordonez I am planning to merge this PR to master, but it looks like demo notebook and associated parameter files are in a different branch, which may have branched out from @msahn's other branch for another precip metric. I was looking for merging that branch into this branch for the notebook, but then it will bring the ongoing another precip metric into this branch. What would be the best way to bring your notebook for this PR to the master? Would you be able to pull only notebooks from your branch to this branch (or the main branch, whatever works easier to you)?

[acordonez]

@lee1043 @msahn The notebook in my 731 branch is for the variability_across_timescales_PS_driver.py and calc_ratio.py scripts, so if those are the right metrics for this branch then yes, that's the notebook. I should be able to pull all the PMP updates into that branch. Once it's updated it could be merged into this branch.

[lee1043]

@acordonez thanks for your comment. I see in the 731_ao_precip_benchmark_nb branch the following directory is included: pcmdi_metrics/precip_distribution, while this PR is for pcmdi_metrics/precip_variability. I think @msahn is still working on the precip_distribution metric (please correct me if I am wrong), so I just wanted to make sure avoiding the precip_distribution codes to be accidentally merged to main (via this PR) when pulling the 731_ao_precip_benchmark_nb into this branch for the notebook.

[acordonez]

@msahn @lee1043 I opened a PR into this branch (not main) with just the jupyter notebook and parameter file: #823

[gleckler1]

@msahn @acordonez @lee1043 precip variability is looking great including demo. I agree the precip_distribution should not be included in the PR.

[acordonez]

@lee1043 @msahn I pulled this branch and tested the notebook, and found a couple of fixes were still needed. Here's the PR with those: #824

[lee1043]

@acordonez thank you for the fix!