Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style fix for precip variabliity codes #822

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Nov 20, 2021

@msahn in this PR, I've separated code style change for your branch. Code style checkup and revisions were done by pre-commt (as documented here), which now required for Github Action CI process.

Can you please check to see if any influence to the result? I suspect not, because all changes in this PR to your branch is only for code style, but just in case it would be safer to check result consistency before merging this to your branch.

@lee1043 lee1043 requested a review from msahn November 20, 2021 05:11
@msahn
Copy link
Collaborator

msahn commented Nov 24, 2021

@msahn in this PR, I've separated code style change for your branch. Code style checkup and revisions were done by pre-commt (as documented here), which now required for Github Action CI process.

Can you please check to see if any influence to the result? I suspect not, because all changes in this PR to your branch is only for code style, but just in case it would be safer to check result consistency before merging this to your branch.

Thank you for modifying the code style. I have checked the analysis result with the modified code and found that the modification does not influence the analysis result.

@lee1043
Copy link
Contributor Author

lee1043 commented Nov 26, 2021

@msahn Excellent, thank you for checking it!

@lee1043 lee1043 merged commit b6dfdb6 into 731_msa_precip_variability Nov 26, 2021
@lee1043 lee1043 deleted the 731_msa_precip_variability_ljw_for_pre-commit branch November 26, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants