Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing new vcs #588

Merged
merged 1 commit into from
Dec 21, 2018
Merged

testing new vcs #588

merged 1 commit into from
Dec 21, 2018

Conversation

doutriaux1
Copy link
Contributor

No description provided.

@doutriaux1
Copy link
Contributor Author

@scottwittenburg let's look at these as well

@doutriaux1
Copy link
Contributor Author

@scottwittenburg, logo is stretched

@scottwittenburg
Copy link

@doutriaux1, will do.

@scottwittenburg
Copy link

@doutriaux1 The vcs PR fixed the logo stretching for me locally, but some of the other tests I couldn't run due to some missing json files. For example:

()
()
()
()
---------------------------------------------------
('RUNNING:', '/data/scott/projects/pcmdi/pcmdi_metrics/tests/pcmdi/basic_test_parameters_file.py')
---------------------------------------------------
()
()
()
()
E
======================================================================
ERROR: testParam (test_pmp_basic_test_parameters_file.PMPParamTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/scott/projects/pcmdi/pcmdi_metrics/tests/test_pmp_basic_test_parameters_file.py", line 7, in testParam
    self.runPMP(param)
  File "/data/scott/projects/pcmdi/pcmdi_metrics/tests/basepmpdriver.py", line 34, in runPMP
    parser = create_mean_climate_parser()
  File "/data/scott/projects/pcmdi/pcmdi_metrics/pcmdi_metrics/pcmdi/mean_climate_metrics_driver.py", line 223, in create_mean_climate_parser
    parser = pcmdi_metrics.driver.pmp_parser.PMPMetricsParser()
  File "/data/scott/projects/pcmdi/pcmdi_metrics/pcmdi_metrics/driver/pmp_parser.py", line 24, in __init__
    *args, **kwargs)
  File "/data/scott/Documents/miniconda2/envs/cdat-nightly-ogl2/lib/python2.7/site-packages/cdp/cdp_parser.py", line 30, in __init__
    self.load_default_args(default_args_file)
  File "/data/scott/Documents/miniconda2/envs/cdat-nightly-ogl2/lib/python2.7/site-packages/cdp/cdp_parser.py", line 580, in load_default_args
    if self.load_default_args_from_json(files):
  File "/data/scott/Documents/miniconda2/envs/cdat-nightly-ogl2/lib/python2.7/site-packages/cdp/cdp_parser.py", line 516, in load_default_args_from_json
    with open(afile) as json_file:
IOError: [Errno 2] No such file or directory: '/data/scott/Documents/miniconda2/envs/cdat-nightly-ogl2/share/cia/DefArgsCIA.json'

----------------------------------------------------------------------
Ran 1 test in 0.005s

FAILED (errors=1)

@doutriaux1
Copy link
Contributor Author

@scottwittenburg you need to add the cia package from pcmdi/label/nightly conda channel.

@doutriaux1
Copy link
Contributor Author

@scottwittenburg looks like the logo is still stretched here.

@scottwittenburg
Copy link

@doutriaux1 I don't think I get how it should have been fixed here if the fix hasn't been merged in vcs yet.

@doutriaux1
Copy link
Contributor Author

@scottwittenburg yes, too many PR and issues at once in my browser (and head). Testing on my mac here. Please add a test to the vcs branch though.

@doutriaux1
Copy link
Contributor Author

@scottwittenburg your vcs fix makes pcmdi_metrics pass w/o changes! As soon as you add the test I will merge in. Thx!

@coveralls
Copy link

coveralls commented Dec 20, 2018

Pull Request Test Coverage Report for Build 775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 74.492%

Files with Coverage Reduction New Missed Lines %
tests/basepmpdriver.py 1 90.63%
tests/basepmp.py 15 55.32%
Totals Coverage Status
Change from base Build 753: -0.4%
Covered Lines: 2935
Relevant Lines: 3940

💛 - Coveralls

@doutriaux1 doutriaux1 merged commit 0bebaab into master Dec 21, 2018
@gleckler1 gleckler1 deleted the context2d branch March 31, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants