Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aspect ratio of logo image so it is not stretched or squashed #376

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

scottwittenburg
Copy link
Collaborator

No description provided.

@scottwittenburg
Copy link
Collaborator Author

@doutriaux1 Any idea why every test is failing with the following stack trace?

======================================================================
ERROR: Failure: ImportError (/home/circleci/project/workspace/test_linux_vcs_py2/miniconda/envs/py2/lib/python2.7/site-packages/cdtime/_cdtime.so: undefined symbol: _gfortran_malloc)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/project/workspace/test_linux_vcs_py2/miniconda/envs/py2/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/home/circleci/project/workspace/test_linux_vcs_py2/miniconda/envs/py2/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/home/circleci/project/workspace/test_linux_vcs_py2/miniconda/envs/py2/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/circleci/project/tests/test_vcs_animate_isoline_colored.py", line 1, in <module>
    import basevcstest
  File "/home/circleci/project/tests/basevcstest.py", line 5, in <module>
    import vcs
  File "/home/circleci/project/vcs/__init__.py", line 106, in <module>
    from .utils import *  # noqa
  File "/home/circleci/project/vcs/utils.py", line 17, in <module>
    import cdtime
  File "/home/circleci/project/workspace/test_linux_vcs_py2/miniconda/envs/py2/lib/python2.7/site-packages/cdtime/__init__.py", line 8, in <module>
    from .compreltime import *
  File "/home/circleci/project/workspace/test_linux_vcs_py2/miniconda/envs/py2/lib/python2.7/site-packages/cdtime/compreltime.py", line 2, in <module>
    from . import _cdtime
ImportError: /home/circleci/project/workspace/test_linux_vcs_py2/miniconda/envs/py2/lib/python2.7/site-packages/cdtime/_cdtime.so: undefined symbol: _gfortran_malloc
----------------------------------------------------------------------

@doutriaux1
Copy link
Contributor

@dnadeau4 it propagated everywhere. It is now an emergency to figure out why cdtime suddenly fails.

@doutriaux1
Copy link
Contributor

@dnadeau4 actually it looks like it needs gfortran now... Why would cdtime need gfortran?

@doutriaux1
Copy link
Contributor

I removed yesterday Linux builds. Fingers crossed.

@doutriaux1
Copy link
Contributor

@scottwittenburg it's passing now that I removed the faulty cdtime. @dnadeau4 we still need to investigate that cdtime issue though... 😢

@doutriaux1
Copy link
Contributor

@scottwittenburg we should add a test for this.

@scottwittenburg
Copy link
Collaborator Author

Agreed @doutriaux1 I'll add a test.

@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage increased (+0.03%) to 70.891% when pulling 2ad0f73 on fix-logo-aspect-ratio into c7a9768 on master.

Copy link
Contributor

@doutriaux1 doutriaux1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove .last_failure and tests/test_vcs_png_window_resize2_.png files
Thx for adding a test

Also add two new tests that make sure logo stays the right aspect
ratio whether the canvas is tall/narrow or short/wide.
@scottwittenburg
Copy link
Collaborator Author

Gah! Sorry about that @doutriaux1, it's too easy to just say git add tests vcs I guess.

@doutriaux1 doutriaux1 merged commit dadf5d0 into master Dec 19, 2018
@scottwittenburg scottwittenburg deleted the fix-logo-aspect-ratio branch December 19, 2018 19:58
@doutriaux1 doutriaux1 added this to the 8.1 milestone Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants