Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup development environment #77

Merged
merged 6 commits into from
Mar 20, 2022
Merged

Conversation

lahdjirayhan
Copy link
Contributor

This PR attempts to solve #55 by configuring black and flake8. Also, as initially mentioned in #68, I've added pre-commit config that runs before every commit:

  • mypy
  • flake8
  • black
  • check file for trailing whitespace
  • make sure file ends in a newline

While I'm at it, additionally I work on adding a guide to setup a development environment in CONTRIBUTING (issue #54). However 1) I feel I can't wedge in the guide anywhere appropriately, and 2) I also felt CONTRIBUTING can be more concise. Based on those two things, I revamped the CONTRIBUTING at the same time as I added the guide.

I do realize and am aware that the writing style is significantly different from the previous CONTRIBUTING... Feel free to add changes if necessary.

Copy link
Collaborator

@Milind220 Milind220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great stuff! Really comprehensive and I'm excited to try it all out.

I've listed a few small changes with the style of contributing.md, once they're addressed I'll merge it in :)

Thanks a lot !

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
- Change all-uppercase back to title case
- Move greeting line back to top
Copy link
Collaborator

@Milind220 Milind220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Milind220 Milind220 merged commit ead92f9 into Ozon3Org:dev Mar 20, 2022
@lahdjirayhan lahdjirayhan deleted the setup-dev branch April 23, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a virtual env setup guide for development of Ozone in the CONTRIBUTING file
2 participants