chore: add mypy linter, black and flake8 as development dependencies #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Wouldn't it be best to also add a Maybe can be done in another PR, though. |
|
@lahdjirayhan indeed you are correct , I was thinking of doing this as the next step by taking example of this famous pipeline which also makes use of pre commit hooks as detailed here , but yeah this will have to be done in another pull request which will also address issue #54 |
Milind220
approved these changes
Mar 16, 2022
|
Thanks @Sam-damn, and good idea @lahdjirayhan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.