Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] add custom file name and warning for not changing file name #129

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

ShootGan
Copy link
Contributor

@ShootGan ShootGan commented Apr 24, 2022

issue #117
add the option to pass the custom file name and waring if this name was default.
[Tests]
Tested by pytest class. I'm not sure how to add this to the current test environment

@Milind220 Milind220 changed the title [bug] add custom file name and warnig for not chaning file name [bug] add custom file name and warning for not changing file name Apr 24, 2022
@Milind220
Copy link
Collaborator

Tested by pytest class. I'm not sure how to add this to the current test environment

No worries, We'll add a separate issue to add a test for it later

Copy link
Collaborator

@Milind220 Milind220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Merging now :) Thanks for your first contribution to Ozone!

@Milind220 Milind220 merged commit a365849 into Ozon3Org:dev Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants