Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: No way to set custom name for file, if saving data as CSV, Excel or JSON file. Also inconsistency in naming. #117

Closed
Milind220 opened this issue Apr 20, 2022 · 5 comments
Assignees
Labels
beginner Slightly more complex than 'good first issue', but not difficult either bug Something isn't working

Comments

@Milind220
Copy link
Collaborator

Current behaviour

All saved files of the same type have the exact same name. This means that if I try to save multiple CSV files, they just overwrite the previous ones. For example:

  • CSV files are named 'air_quality.csv'
  • Excel files are named 'air_quality_data.csv'
  • Excel files are named 'air_quality_data.json'

Desired behaviour

  • Users should have the option to custom name their files should they choose to save their data as a file.
  • If they choose to save their data as a file instead of a dataframe, a warning should tell users that they should give the file a unique name to avoid previous files from being overwritten.
@Milind220 Milind220 added bug Something isn't working beginner Slightly more complex than 'good first issue', but not difficult either labels Apr 20, 2022
@ShootGan
Copy link
Contributor

I can try to work on that. Can you assign me?

@lahdjirayhan
Copy link
Contributor

@ShootGan Of course! See this section on CONTRIBUTING about how to make an issue get assigned to you automatically!

@ShootGan
Copy link
Contributor

Hold my beer, I got this

@ShootGan
Copy link
Contributor

On commit i get error ImportError: cannot import name '_unicodefun' from 'click' (C:\Users\p_nal\.cache\pre-commit\repo99_g8q2e\py_env-python3.8\ lib\site-packages\click\__init__.py)

@Milind220
Copy link
Collaborator Author

Milind220 commented Apr 24, 2022

@ShootGan hey! This is an issue with the pre commit hooks (the thing that checks if your commit follows our style guide or not). This is caused by a slightly outdated version of Black, but has been fixed since in the dev branch.

I'm assuming you've already setup your development environment according to the guidelines in the contributing.md file.
To get the latest updates, you need to pull from the upstream dev branch:
git pull upstream dev:dev

Then reinstall the pre-commit hooks
pre-commit install

It should work fine with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Slightly more complex than 'good first issue', but not difficult either bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants