Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Force convert into float (np.nan if fails) #126

Merged
merged 3 commits into from
Apr 23, 2022
Merged

fix: Force convert into float (np.nan if fails) #126

merged 3 commits into from
Apr 23, 2022

Commits on Apr 23, 2022

  1. fix: Add helper method to convert into float, or numpy.nan if fails

    @lahdjirayhan
    lahdjirayhan committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    4e53b54 View commit details
    Browse the repository at this point in the history

  2. fix: Return invalid description instead of raising exception 

    This will allow for invalid AQIs (e.g., np.nan) to be passed without
raising exception. This can better handle cases where WAQI data is out of bound.
I've personally seen cases of AQI values '999' and '-'.
    @lahdjirayhan
    lahdjirayhan committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    bb34bd2 View commit details
    Browse the repository at this point in the history

  3. fix: Make _as_float private

    @lahdjirayhan
    lahdjirayhan committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    1873323 View commit details
    Browse the repository at this point in the history