fix: Force convert into float (np.nan if fails) #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for invalid AQIs (e.g., np.nan) to be passed without raising exception. This can better handle cases where WAQI data is out of bound. I've personally seen cases of AQI values '999' and '-'.
Milind220
previously approved these changes
Apr 23, 2022
Milind220
dismissed
their stale review
Need to request changes, approved by accident
Milind220
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve the problem previously written up in #120 (comment) (point no 2)
It introduces a helper method that tries to convert its input into float, and if that fails, gives out
numpy.nan.In light of the fact that WAQI backend sometimes sends invalid AQI value (e.g.
-as noted above), I've also modified the_AQI_meaningmethod to return an "invalid" description rather than raising exception, to allow values such asnp.nanto be given as its input without raising exceptions,