-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipettes): add acceleration to TipActionRequest message #653
Conversation
Codecov Report
@@ Coverage Diff @@
## main #653 +/- ##
=======================================
Coverage 84.30% 84.30%
=======================================
Files 87 87
Lines 3836 3836
=======================================
Hits 3234 3234
Misses 602 602
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to edit:
include/motor-control/core/stepper-motor/motion_controller.hpp::PipetteMotionController
in order for the acceleration to actually get used (and I believe the pip motion controller task too).
Let me know if you can't find where these are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep looks good, but please don't merge in till the python pr is ready to be merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just in case so we don't drive ourselves crazy if we flash the wrong thing, can we put the acceleration part at the end of the message and set it to 0 if we don't have a long enough message to include it
Looks good otherwise though! |
9a72d80
to
40f1d65
Compare
930951b
to
1752888
Compare
4c74d43
to
e3feadb
Compare
1fb16e2
to
a6b38bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Really great work.
This code accompanies the monorepo changes in this pr- it adds acceleration to
TipActionRequest
messages, and uses theposition_flags
parameter inGearMotorAck
s after a move is complete