Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api direct movements within well #839

Merged
merged 6 commits into from
Feb 23, 2018
Merged

Conversation

andySigler
Copy link
Contributor

overview

When a pipette.move_to() is called on the same well as before, it will run a 'direct' path instead of an 'arc' path, so that there are no pointless up-and-down motions when performing multiple commands within the same well.

@andySigler andySigler added feature Ticket is a feature request / PR introduces a feature api Affects the `api` project ready for review labels Feb 14, 2018
@andySigler andySigler self-assigned this Feb 14, 2018
@andySigler andySigler added this to To do in Sprint Week of 2018-02-13 via automation Feb 14, 2018
@andySigler andySigler force-pushed the api-direct-movements-within-well branch from 58159c5 to ff57a2d Compare February 14, 2018 23:25
@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #839 into v3a will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              v3a     #839      +/-   ##
==========================================
+ Coverage   69.05%   69.12%   +0.06%     
==========================================
  Files         224      224              
  Lines        6868     6879      +11     
  Branches      278      278              
==========================================
+ Hits         4743     4755      +12     
+ Misses       2043     2042       -1     
  Partials       82       82
Impacted Files Coverage Δ
api/opentrons/instruments/pipette.py 96.37% <100%> (-0.12%) ⬇️
api/opentrons/containers/placeable.py 95.19% <0%> (+0.3%) ⬆️
api/opentrons/util/vector.py 84.48% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77004e...ad4d417. Read the comment docs.

@btmorr btmorr moved this from To do to In progress in Sprint Week of 2018-02-13 Feb 16, 2018
@andySigler andySigler force-pushed the api-direct-movements-within-well branch from 62575a2 to c5469e3 Compare February 19, 2018 16:26
@andySigler andySigler moved this from In progress to In Review in Sprint Week of 2018-02-13 Feb 19, 2018
@umbhau umbhau added this to To do in Sprint Week of 2018-02-20 via automation Feb 23, 2018
@umbhau umbhau removed this from In Review in Sprint Week of 2018-02-13 Feb 23, 2018
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the following protocol:

from opentrons import containers, instruments, robot


rack1 = containers.load('tiprack-10ul', '3')
rack2 = containers.load('tiprack-200ul', '6')

plate = containers.load('96-flat', '1')


p10_single = instruments.P10_Single(
   mount='right',
   tip_racks=[rack1]
   )

p300_multi = instruments.P300_Multi(
   mount='left',
   tip_racks=[rack2]
   )


p10_single.pick_up_tip()
p10_single.aspirate(5, plate.wells('A1'))
p10_single.dispense(5, plate.wells('B1'))
p10_single.move_to(plate.wells('B5'))
p10_single.drop_tip()

p300_multi.pick_up_tip()
p300_multi.aspirate(40, plate.wells('A1'))
p300_multi.dispense(40, plate.wells('A2'))
p300_multi.move_to(plate.wells('A6'))
p300_multi.drop_tip()
  • Good speed
  • Moves through the plate without a large change in z height

@Laura-Danielle Laura-Danielle moved this from To do to In Review in Sprint Week of 2018-02-20 Feb 23, 2018
@andySigler andySigler merged commit ecd5302 into v3a Feb 23, 2018
Sprint Week of 2018-02-20 automation moved this from In Review to Done Feb 23, 2018
@andySigler andySigler deleted the api-direct-movements-within-well branch February 23, 2018 22:17
@btmorr btmorr added the small label Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project feature Ticket is a feature request / PR introduces a feature small
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants