Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(robot-server): Refactor hardware wrapper and other lifetime dependencies #8213

Closed
wants to merge 49 commits into from
Closed

fix(robot-server): Refactor hardware wrapper and other lifetime dependencies #8213

Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
e77dd78
Create `slow_initializing` module.
SyntaxColoring Jul 29, 2021
686b1fa
Make `API.register_callback()` non-async.
SyntaxColoring Aug 3, 2021
3e89b33
Eliminate HardwareWrapper.
SyntaxColoring Aug 4, 2021
fca92e0
WIP: Comment out tests.
SyntaxColoring Aug 9, 2021
752fabb
WIP.
SyntaxColoring Aug 9, 2021
656a100
Work around `request` being inaccessible from WebSocket endpoints.
SyntaxColoring Aug 9, 2021
0f2ea16
Rename hardware_wrapper.py -> hardware_initialization.py.
SyntaxColoring Aug 9, 2021
d7b29eb
Make _make_event_publisher() non-async, and leave .close() todo.
SyntaxColoring Aug 9, 2021
bf04ca4
Cleanup.
SyntaxColoring Aug 9, 2021
4dfa729
Uncomment and start fixing up tests.
SyntaxColoring Aug 9, 2021
bf31cc0
Todo for hardware shutdown.
SyntaxColoring Aug 9, 2021
e6bc2e4
Make _init_event_watchers non-async.
SyntaxColoring Aug 9, 2021
ab183c3
Port test_slow_initializing.py to Decoy.
SyntaxColoring Aug 10, 2021
3e0f901
Delete unnecessary comments about BaseException.
SyntaxColoring Aug 10, 2021
e3eb9bd
WIP: refactor app lifetime dependencies.
SyntaxColoring Aug 4, 2021
9428465
Tests: override motion lock dependency with a mock.
SyntaxColoring Aug 4, 2021
6a33398
Documentation and minor cleanup.
SyntaxColoring Aug 4, 2021
c389c36
Rename app_dependencies.py to lifetime_dependencies.py.
SyntaxColoring Aug 10, 2021
7c62bf8
Improve module docstring.
SyntaxColoring Aug 10, 2021
bcb6397
More WIP of lifetime dependencies.
SyntaxColoring Aug 10, 2021
f2d54fb
Clarify comment.
SyntaxColoring Aug 11, 2021
e42916b
Move some stuff around.
SyntaxColoring Aug 11, 2021
602eb75
Cleanup, and fix circular import.
SyntaxColoring Aug 11, 2021
0afd56a
Formatting.
SyntaxColoring Aug 11, 2021
c0dfca8
Linting.
SyntaxColoring Aug 11, 2021
c818120
Delete unnecessary comment.
SyntaxColoring Aug 11, 2021
697e2fd
Format and lint.
SyntaxColoring Aug 11, 2021
5ab454b
Rewrite `HardwareWrapper` tests for `hardware_initialization` module.
SyntaxColoring Aug 12, 2021
1aa55bd
Format and lint.
SyntaxColoring Aug 11, 2021
6552b3c
Merge lifetime dependency refactors.
SyntaxColoring Aug 12, 2021
774cfb4
Lint.
SyntaxColoring Aug 12, 2021
3a95844
Override with a *real* motion lock, to preserve existing behavior.
SyntaxColoring Aug 13, 2021
b6d95af
Port ProtocolManager and SessionManager cleanup code.
SyntaxColoring Aug 13, 2021
3b854b2
Delete obsolete comment.
SyntaxColoring Aug 13, 2021
dc5032d
Handle `InitializationOngoingError` in `get_rpc_server()` (sort of).
SyntaxColoring Aug 13, 2021
b7ac395
Clean up some of `lifetime_dependencies`' imports.
SyntaxColoring Aug 13, 2021
8827b2f
Delete unnecessary todo comment.
SyntaxColoring Aug 13, 2021
3573b80
Don't unnecessarily wrap `motion_lock` in a context manager.
SyntaxColoring Aug 13, 2021
59d46f3
Clarify a comment.
SyntaxColoring Aug 13, 2021
615e06a
Remove now-unnecessary `@call_once` decorators.
SyntaxColoring Aug 13, 2021
8d06237
Remove print debug statements.
SyntaxColoring Aug 14, 2021
abd5d19
Remove unused import.
SyntaxColoring Aug 14, 2021
72a47dd
Remove resolved todo.
SyntaxColoring Aug 16, 2021
1c8d3b9
Rename `lifetime_dependency_set` args to `lifetime_dependencies`.
SyntaxColoring Aug 17, 2021
84a6ff6
Add some docstrings to `lifetime_dependencies` internal functions.
SyntaxColoring Aug 17, 2021
a960dd1
Make small improvements to how we store dependencies on `app`.
SyntaxColoring Aug 18, 2021
b3593da
Fix startup accidentally waiting for `ThreadManager` to be ready.
SyntaxColoring Aug 18, 2021
233ef3d
Reformat.
SyntaxColoring Aug 18, 2021
5343b36
Make `API.register_callback()` async again.
SyntaxColoring Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename app_dependencies.py to lifetime_dependencies.py.
  • Loading branch information
@SyntaxColoring
SyntaxColoring committed Aug 10, 2021
commit c389c369edf40339374cfaa634e11d247dde30a1
0 ...t-server/robot_server/app_dependencies.py → ...ver/robot_server/lifetime_dependencies.py
View file
Open in desktop
File renamed without changes.