Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(robot-server): Refactor hardware wrapper and other lifetime dependencies #8213

Closed
wants to merge 49 commits into from
Closed

fix(robot-server): Refactor hardware wrapper and other lifetime dependencies #8213

wants to merge 49 commits into from

Commits on Aug 9, 2021

  1. Create slow_initializing module.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    e77dd78 View commit details
    Browse the repository at this point in the history

  2. Make API.register_callback() non-async.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    686b1fa View commit details
    Browse the repository at this point in the history

  3. Eliminate HardwareWrapper.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    3e89b33 View commit details
    Browse the repository at this point in the history

  4. WIP: Comment out tests.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    fca92e0 View commit details
    Browse the repository at this point in the history

  5. WIP.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    752fabb View commit details
    Browse the repository at this point in the history

  6. Work around request being inaccessible from WebSocket endpoints.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    656a100 View commit details
    Browse the repository at this point in the history

  7. Rename hardware_wrapper.py -> hardware_initialization.py.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    0f2ea16 View commit details
    Browse the repository at this point in the history

  8. Make _make_event_publisher() non-async, and leave .close() todo.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    d7b29eb View commit details
    Browse the repository at this point in the history

  9. Cleanup.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    bf04ca4 View commit details
    Browse the repository at this point in the history

  10. Uncomment and start fixing up tests.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    4dfa729 View commit details
    Browse the repository at this point in the history

  11. Todo for hardware shutdown.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    bf31cc0 View commit details
    Browse the repository at this point in the history

  12. Make _init_event_watchers non-async.

    @SyntaxColoring
    SyntaxColoring committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    e6bc2e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Port test_slow_initializing.py to Decoy.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    ab183c3 View commit details
    Browse the repository at this point in the history

  2. Delete unnecessary comments about BaseException.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    3e0f901 View commit details
    Browse the repository at this point in the history

  3. WIP: refactor app lifetime dependencies.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    e3eb9bd View commit details
    Browse the repository at this point in the history

  4. Tests: override motion lock dependency with a mock.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    9428465 View commit details
    Browse the repository at this point in the history

  5. Documentation and minor cleanup.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    6a33398 View commit details
    Browse the repository at this point in the history

  6. Rename app_dependencies.py to lifetime_dependencies.py.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    c389c36 View commit details
    Browse the repository at this point in the history

  7. Improve module docstring.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    7c62bf8 View commit details
    Browse the repository at this point in the history

  8. More WIP of lifetime dependencies.

    @SyntaxColoring
    SyntaxColoring committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    bcb6397 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Clarify comment.

    @SyntaxColoring
    SyntaxColoring committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    f2d54fb View commit details
    Browse the repository at this point in the history

  2. Move some stuff around.

    @SyntaxColoring
    SyntaxColoring committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    e42916b View commit details
    Browse the repository at this point in the history

  3. Cleanup, and fix circular import.

    @SyntaxColoring
    SyntaxColoring committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    602eb75 View commit details
    Browse the repository at this point in the history

  4. Formatting.

    @SyntaxColoring
    SyntaxColoring committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    0afd56a View commit details
    Browse the repository at this point in the history

  5. Linting.

    @SyntaxColoring
    SyntaxColoring committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    c0dfca8 View commit details
    Browse the repository at this point in the history

  6. Delete unnecessary comment.

    @SyntaxColoring
    SyntaxColoring committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    c818120 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Format and lint.

    @SyntaxColoring
    SyntaxColoring committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    697e2fd View commit details
    Browse the repository at this point in the history

  2. Rewrite HardwareWrapper tests for hardware_initialization module.

    @SyntaxColoring
    SyntaxColoring committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    5ab454b View commit details
    Browse the repository at this point in the history

  3. Format and lint.

    @SyntaxColoring
    SyntaxColoring committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    1aa55bd View commit details
    Browse the repository at this point in the history

  4. Merge lifetime dependency refactors. 

    Merged from #8232.
    @SyntaxColoring
    SyntaxColoring committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    6552b3c View commit details
    Browse the repository at this point in the history

  5. Lint.

    @SyntaxColoring
    SyntaxColoring committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    774cfb4 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Override with a *real* motion lock, to preserve existing behavior.

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    3a95844 View commit details
    Browse the repository at this point in the history

  2. Port ProtocolManager and SessionManager cleanup code.

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    b6d95af View commit details
    Browse the repository at this point in the history

  3. Delete obsolete comment.

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    3b854b2 View commit details
    Browse the repository at this point in the history

  4. Handle InitializationOngoingError in get_rpc_server() (sort of).

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    dc5032d View commit details
    Browse the repository at this point in the history

  5. Clean up some of lifetime_dependencies' imports.

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    b7ac395 View commit details
    Browse the repository at this point in the history

  6. Delete unnecessary todo comment. 

    We can discuss this during review.
    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    8827b2f View commit details
    Browse the repository at this point in the history

  7. Don't unnecessarily wrap motion_lock in a context manager.

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    3573b80 View commit details
    Browse the repository at this point in the history

  8. Clarify a comment.

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    59d46f3 View commit details
    Browse the repository at this point in the history

  9. Remove now-unnecessary @call_once decorators.

    @SyntaxColoring
    SyntaxColoring committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    615e06a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Remove print debug statements. 

    How embarrassing!
    @SyntaxColoring
    SyntaxColoring committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    8d06237 View commit details
    Browse the repository at this point in the history

  2. Remove unused import.

    @SyntaxColoring
    SyntaxColoring committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    abd5d19 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Remove resolved todo.

    @SyntaxColoring
    SyntaxColoring committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    72a47dd View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Rename lifetime_dependency_set args to lifetime_dependencies.

    @SyntaxColoring
    SyntaxColoring committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    1c8d3b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Add some docstrings to lifetime_dependencies internal functions.

    @SyntaxColoring
    SyntaxColoring committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    84a6ff6 View commit details
    Browse the repository at this point in the history

  2. Make small improvements to how we store dependencies on app. 

    * Fix `_set()` not being used.
* Rename `_set()` to `_store_on_app()`.
* Add `_delete_stored_on_app()` and use it on cleanup.
    @SyntaxColoring
    SyntaxColoring committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    a960dd1 View commit details
    Browse the repository at this point in the history

  3. Fix startup accidentally waiting for ThreadManager to be ready.

    @SyntaxColoring
    SyntaxColoring committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    b3593da View commit details
    Browse the repository at this point in the history

  4. Reformat.

    @SyntaxColoring
    SyntaxColoring committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    233ef3d View commit details
    Browse the repository at this point in the history

  5. Make API.register_callback() async again. 

    Partially reverts commit 686b1fa.
    @SyntaxColoring
    SyntaxColoring committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    5343b36 View commit details
    Browse the repository at this point in the history