Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emulator): allow overriding pipettes used by smoothie emulator #7868

Merged
merged 4 commits into from
Jun 3, 2021

Conversation

amitlissack
Copy link
Contributor

@amitlissack amitlissack commented Jun 2, 2021

Overview

Users can define which pipettes are loaded by smoothie emulator

Changelog

  • Added Settings object to emulator app
  • Documented how to override in DOCKER.md
  • Document how to override in README.rst
  • added commented about override in docker-compose.yml

Review requests

Risk assessment

None

@amitlissack amitlissack requested a review from a team June 2, 2021 17:59
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (edge@5bb265f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #7868   +/-   ##
=======================================
  Coverage        ?   83.56%           
=======================================
  Files           ?      345           
  Lines           ?    21509           
  Branches        ?        0           
=======================================
  Hits            ?    17973           
  Misses          ?     3536           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb265f...180c125. Read the comment docs.

@amitlissack amitlissack marked this pull request as ready for review June 2, 2021 18:14
@amitlissack amitlissack requested review from a team as code owners June 2, 2021 18:14
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me though I couldn't test because of dev env problems unfortunately but I will update when I can.

@amitlissack amitlissack merged commit de05ed1 into edge Jun 3, 2021
@amitlissack amitlissack deleted the api-emulator-settings branch June 3, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants