feat(api): move gantry to safe spot while TC lid moves #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate calibration will now be required for instances of the same labware that exist in a given protocol with a different direct parent type (e.g. 'slot', 'thermocycler', 'Magnetic Module'...) Closes #3775
Provide a protection for calls to thermocycler.open() and .close() that prevents the possibility of the lid colliding with the pipettes. Before either command is sent to the module, the gantry will move to a "safe" spot at the highest z above the fixed trash.
b-cooper
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #3805 +/- ##
==========================================
+ Coverage 57.19% 57.19% +<.01%
==========================================
Files 820 820
Lines 22797 22810 +13
==========================================
+ Hits 13038 13046 +8
- Misses 9759 9764 +5
Continue to review full report at Codecov.
|
sfoster1
requested changes
Jul 31, 2019
| self._ctx.loaded_instruments.items() | ||
| if instr is not None] | ||
| try: | ||
| instrument = loaded_instruments[0] |
There was a problem hiding this comment.
Let's try and keep only this line inside the try/catch and return early if it fails so we don't accidentally catch other exceptions.
|
closed in favor of #3807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a protection for calls to thermocycler.open() and .close() that prevents the possibility of
the lid colliding with the pipettes. Before either command is sent to the module, the gantry will
move to a "safe" spot at the highest z above the fixed trash.