Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

561 remove closures #249

Merged
merged 136 commits into from
Jul 12, 2017
Merged

561 remove closures #249

merged 136 commits into from
Jul 12, 2017

Conversation

SimplyAhmazing
Copy link
Contributor

This PR has several impacts,

  • Removes robot singleton
  • Removes command queue closures, api calls are direct calls to driver
  • Removes upload to Jupyter feature (since commands are no longer stored and cannot be serialized)
  • Creates a utils/state.py and refactors methods for querying robot state from flask app
  • Removes JSON importer
  • Removes threaded test for pausing a running protocol as commands are no longer in a queue. This needs to be re-thought
  • Removes enqueue=True from documentation

…:OpenTrons/opentrons-api into 559-refactor-robot-to-not-be-a-singleton
@coveralls
Copy link

coveralls commented Jul 10, 2017

Coverage Status

Coverage decreased (-0.4%) to 90.742% when pulling d1e1410 on 561-remove-closures into 6ef2a95 on develop.

@coveralls
Copy link

coveralls commented Jul 10, 2017

Coverage Status

Coverage decreased (-0.4%) to 90.727% when pulling fcf9655 on 561-remove-closures into 6ef2a95 on develop.

@astaff
Copy link
Contributor

astaff commented Jul 11, 2017

LGTM

@coveralls
Copy link

coveralls commented Jul 11, 2017

Coverage Status

Coverage decreased (-0.4%) to 90.727% when pulling 8c0f9c0 on 561-remove-closures into 6ef2a95 on develop.

@coveralls
Copy link

coveralls commented Jul 11, 2017

Coverage Status

Coverage decreased (-0.4%) to 90.727% when pulling abc0456 on 561-remove-closures into 6ef2a95 on develop.

@coveralls
Copy link

coveralls commented Jul 11, 2017

Coverage Status

Coverage decreased (-0.4%) to 90.727% when pulling abc0456 on 561-remove-closures into 6ef2a95 on develop.

@coveralls
Copy link

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-0.4%) to 90.727% when pulling 1363abb on 561-remove-closures into 6ef2a95 on develop.

@coveralls
Copy link

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-0.4%) to 90.727% when pulling de63147 on 561-remove-closures into 6ef2a95 on develop.

@SimplyAhmazing SimplyAhmazing merged commit b8395f4 into develop Jul 12, 2017
@SimplyAhmazing SimplyAhmazing deleted the 561-remove-closures branch July 12, 2017 14:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 90.711% when pulling f552fea on 561-remove-closures into 6ef2a95 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 90.711% when pulling 158a7f9 on 561-remove-closures into 6ef2a95 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants