Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): add and use deck map component in interventionmodal #15570

Merged
merged 9 commits into from
Jul 5, 2024
Merged

refactor(app): add and use deck map component in interventionmodal #15570

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ecd3295
fix a logic error that prevented recovery from running
sfoster1 Jul 3, 2024
340dc82
refactor(app): separate StandIn story util
sfoster1 Jul 5, 2024
ef2cde7
feat(app): add DeckMapContent
sfoster1 Jul 5, 2024
7b2d00b
and after all, why not? it's mine, isn't it?
sfoster1 Jul 2, 2024
eb1b5d5
refactor: use intervention map in drop tip wizard
sfoster1 Jul 2, 2024
f11485d
refactor: use deckmap in error recovery
sfoster1 Jul 2, 2024
c060b23
fix up remaining tests
sfoster1 Jul 3, 2024
ea5c4be
fix up some render issues
sfoster1 Jul 3, 2024
67a36a8
docs page: allow non-specified onSelect
sfoster1 Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix up some render issues
  • Loading branch information
@sfoster1
sfoster1 committed Jul 5, 2024
commit ea5c4beff6079646d70389d991acd7a46a8420b5
2 changes: 1 addition & 1 deletion app/src/molecules/InterventionModal/TwoColumn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function TwoColumn({
<Box flex="1" minWidth="17.1875rem">
{leftElement}
</Box>
<Box flex="1" minWidth="275px">
<Box flex="1" minWidth="17.1875rem">
{rightElement}
</Box>
</Flex>
Expand Down
19 changes: 16 additions & 3 deletions app/src/organisms/DropTipWizardFlows/ChooseLocation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
DIRECTION_COLUMN,
Flex,
JUSTIFY_SPACE_BETWEEN,
JUSTIFY_FLEX_START,
PrimaryButton,
RESPONSIVENESS,
SPACING,
Expand Down Expand Up @@ -78,7 +79,7 @@ export const ChooseLocation = (
}
}
return (
<Flex>
<Flex css={CONTAINER_STYLE}>
<TwoColumn>
<Flex flexDirection={DIRECTION_COLUMN} flex="1" gap={SPACING.spacing16}>
<Title>{title}</Title>
Expand All @@ -95,7 +96,6 @@ export const ChooseLocation = (
justifyContent={JUSTIFY_SPACE_BETWEEN}
css={ALIGN_BUTTONS}
gridGap={SPACING.spacing8}
marginTop="auto"
>
<Btn
onClick={() => {
Expand All @@ -120,7 +120,7 @@ export const ChooseLocation = (
buttonText={i18n.format(t('move_to_slot'), 'capitalize')}
onClick={handleConfirmPosition}
css={css`
@media not ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
@media not (${RESPONSIVENESS.touchscreenMediaQuerySpecs}) {
display: none;
}
`}
Expand Down Expand Up @@ -155,3 +155,16 @@ const ALIGN_BUTTONS = css`
align-items: ${ALIGN_CENTER};
}
`

const CONTAINER_STYLE = css`
flex-direction: ${DIRECTION_COLUMN};
justify-content: ${JUSTIFY_SPACE_BETWEEN};
padding: ${SPACING.spacing32};
height: 24.625rem;
@media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
justify-content: ${JUSTIFY_FLEX_START};
gap: ${SPACING.spacing32};
padding: none;
height: 29.5rem;
}
`