refactor(app): Wire up Error Recovery flows on desktop #15560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes app-shell-odd getConfig (to match app-shell) so that make -C app dev-odd works
TamarZanzouri
requested review from
shlokamin and
sfoster1
and removed request for
a team
shlokamin
reviewed
Jul 1, 2024
app-shell-odd/src/config/index.ts
Outdated
Comment on lines
125
to
127
| export function getConfig(path?: string): any { | ||
| const result = path == null ? null : store().get(path) | ||
| const over = getOverrides(path) | ||
| export function getConfig(path?: any): any { | ||
| const result = store().get(path) | ||
| const over = getOverrides(path as string | undefined) |
There was a problem hiding this comment.
how come we're changing the app shell's config getter?
There was a problem hiding this comment.
it's gone now that you merged edge into the branch
sfoster1
approved these changes
Jul 1, 2024
aaron-kulkarni
pushed a commit
that referenced
this pull request
Jul 3, 2024
sfoster1
added a commit
that referenced
this pull request
Jul 5, 2024
) #15560 introduced a logic bug that prevented ER from launching on ODD, this fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://opentrons.atlassian.net/browse/EXEC-552.
@mjhuff 's implementation :-) I just fixed the test and put up the PR.
Test Plan
Risk assessment
low.