fix(app): fix a logic error that prevented recovery from running (#15583

)

#15560 introduced a logic bug that prevented ER from launching on ODD,
this fixes it.

app/src/organisms/ErrorRecoveryFlows/RunPausedSplash.tsx

@@ -44,7 +44,7 @@ export function useRunPausedSplash(
  showERWizard: boolean
 ): boolean {
  // Don't show the splash when desktop ER wizard is active.
- return !(!isOnDevice && showERWizard)
+ return isOnDevice && !showERWizard
 }
 
 type RunPausedSplashProps = ERUtilsResults & {

app/src/organisms/ErrorRecoveryFlows/__tests__/RunPausedSplash.test.tsx

@@ -34,11 +34,20 @@ describe('useRunPausedSplash', () => {
  )
  })
 
- it('returns true if on the ODD', () => {
- const { result } = renderHook(() => useRunPausedSplash(true, true), {
- wrapper,
+ const IS_WIZARD_SHOWN = [false, true]
+ IS_WIZARD_SHOWN.forEach(val => {
+ it(`returns ${!val} if on the ODD and showERWizard is ${val}`, () => {
+ const { result } = renderHook(() => useRunPausedSplash(true, val), {
+ wrapper,
+ })
+ expect(result.current).toEqual(!val)
+ })
+ it(`always returns false if on desktop and showERWizard is ${val}`, () => {
+ const { result } = renderHook(() => useRunPausedSplash(false, val), {
+ wrapper,
+ })
+ expect(result.current).toEqual(false)
  })
- expect(result.current).toEqual(true)
  })
 })